Drop maximum_name_length from permissions; move to Constants#49
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 27, 2026
Merged
Conversation
Ports nativeapptemplate/NativeAppTemplate-iOS#59. Two-step cleanup of maximumNameLength: 1. Stop reading maximum_name_length from /shopkeeper/permissions. The client already tolerated its absence via a "?? 100" fallback, so this is dead plumbing. Drops the field from PermissionsResponse, the meta read in PermissionsRequest.handle, and the assignment in SessionController.fetchPermissions. 2. Move maximumNameLength from SessionController to Constants. Now that it's a fixed value, it's just a constant — like maximumItemTagDescriptionLength. Adds NativeAppTemplateConstants.maximumItemTagNameLength = 100, drops maximumNameLength from SessionControllerProtocol / SessionController / NullSessionController / TestSessionController. ItemTagCreateViewModel and ItemTagEditViewModel now read the constant directly and no longer take sessionController. Updates the call sites in ItemTagListView / ItemTagDetailView. Tests rewritten to drop sessionController field and update truncation tests to use 100+ char strings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dadachi
deleted the
substrate-v2--drop-maximum-name-length-from-permissions
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports nativeapptemplate/NativeAppTemplate-iOS#59. Two-step cleanup of `maximumNameLength` now that the server no longer sends `maximum_name_length` in the `/shopkeeper/permissions` meta.
Changes
Step 1 — Stop reading `maximum_name_length` from /shopkeeper/permissions. The client already tolerated its absence via a `?? 100` fallback, so this is dead plumbing. Drops the field from `PermissionsResponse`, the meta read in `PermissionsRequest.handle`, and the assignment in `SessionController.fetchPermissions`.
Step 2 — Move `maximumNameLength` from `SessionController` to `Constants`. Now that it's a fixed value, it's just a constant — like `maximumItemTagDescriptionLength`. Adds `NativeAppTemplateConstants.maximumItemTagNameLength = 100`, drops `maximumNameLength` from `SessionControllerProtocol` / `SessionController` / `NullSessionController` / `TestSessionController`. `ItemTagCreateViewModel` and `ItemTagEditViewModel` now read the constant directly and no longer take `sessionController` (it had no other use in those view models). Updates the two call sites in `ItemTagListView` / `ItemTagDetailView`. Tests rewritten: drop `sessionController` field, remove all `sessionController.maximumNameLength = N` overrides, and update the two truncation tests to use 100+ char strings against the constant.
Test plan
🤖 Generated with Claude Code